ref(e2e): Add waitForStatusCode helper and use it in checkIfBuilds
#766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o look for status code 0 instead of arbitrary stdout strings Recently, Nuxt started using `consola` which seems to not pipe output back to stdout which in turn made our e2e tests fail. Rather that checking arbitrary strings frameworks output at the end of their build commands, we switch to checking that the build process exited with status code 0.
Lms24
approved these changes
Jan 22, 2025
andreiborza
added a commit
that referenced
this pull request
Jan 22, 2025
…o look for (#766) status code 0 instead of arbitrary stdout strings Recently, Nuxt started using `consola` which seems to not pipe output back to stdout which in turn made our e2e tests fail. Rather that checking arbitrary strings frameworks output at the end of their build commands, we switch to checking that the build process exited with status code 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Nuxt started using
consolawhich seems to not pipe output back to stdout which in turn made our e2e tests fail.Rather that checking arbitrary strings frameworks output at the end of their build commands, we switch to checking that the build process exited with status code 0.
The other changes in this PR come from running the formatter.
#skip-changelog