-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change access modifier to private
for stack trace mode option setter
#1806
Conversation
private
for stack trace mode option setter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the whole property was private
though (getter and setter). We're making the getter public but the setter private. Is this helping somehow?
What we wanted to achieve was take away the footgun for users to switch mode and break their game by hiding the property. But it's still accessible via the base class. With this we're giving the "no-footgun!" attempt a second chance. |
As per my comment, isnt' the whole thing |
Co-authored-by: Bruno Garcia <[email protected]>
Making the property private on the child only hides it on the child. Accessing the property i.e. in the configure callback falls back directly to the Keeping the property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding this!
Added some additional context as to why the change.
Thank you for clarifying that |
This PR should prevent users from accidentally enabling
Enhanced
stack trace mode via theSentryUnityOptions
parent class property. Enhanced mode is not supported in IL2CPP builds (see #1033 for more details) and thus could cause crashes like in #1783.Closes #1783