fix: Don't block on sending envelopes #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 70.88% 70.87% -0.02%
==========================================
Files 66 66
Lines 6623 6624 +1
==========================================
Hits 4695 4695
- Misses 1928 1929 +1 |
kamilogorek
reviewed
Feb 3, 2023
| @@ -85,7 +85,12 @@ impl TransportThread { | |||
| } | |||
|
|
|||
| pub fn send(&self, envelope: Envelope) { | |||
| let _ = self.sender.send(Task::SendEnvelope(envelope)); | |||
| // Using send here would mean that when the channel fills up for whatever | |||
There was a problem hiding this comment.
In JS we indeed just drop the envelope - https://github.com/getsentry/sentry-javascript/blob/e497bcda305a9c248dcdc78f48fe548cc58f8233/packages/core/src/transports/base.ts#L93-L104
kamilogorek
approved these changes
Feb 3, 2023
Swatinem
reviewed
Feb 3, 2023
Swatinem
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #543.
I am unsure if there is anything better than
eprintlnwe can do in the error case—would using e.g. thesentry_debugmacro exacerbate the problem because it also tries to send on the same channel?