-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc(samples): Update Gemfile missing x86 ffi #4569
Conversation
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 375.37 ms | 395.14 ms | 19.77 ms |
3f05680 | 397.91 ms | 405.65 ms | 7.74 ms |
6e8584e | 447.10 ms | 474.71 ms | 27.61 ms |
a0df630 | 436.87 ms | 472.53 ms | 35.66 ms |
0d3e677 | 422.82 ms | 411.90 ms | -10.92 ms |
d997097 | 470.23 ms | 475.46 ms | 5.23 ms |
9a3ca65+dirty | 326.93 ms | 330.14 ms | 3.21 ms |
d361d38 | 354.10 ms | 381.69 ms | 27.59 ms |
2ec71da | 438.14 ms | 460.46 ms | 22.32 ms |
3aecc61 | 479.21 ms | 462.92 ms | -16.29 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d0bf494+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
3f05680 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
6e8584e | 17.73 MiB | 19.86 MiB | 2.12 MiB |
a0df630 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
0d3e677 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
d997097 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
9a3ca65+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
d361d38 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
2ec71da | 17.73 MiB | 20.10 MiB | 2.37 MiB |
3aecc61 | 17.74 MiB | 20.10 MiB | 2.36 MiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 1230.63 ms | 1234.83 ms | 4.20 ms |
e99226d+dirty | 1217.50 ms | 1222.18 ms | 4.68 ms |
3aecc61+dirty | 1237.75 ms | 1237.42 ms | -0.33 ms |
6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
700cbf4+dirty | 1234.59 ms | 1227.71 ms | -6.88 ms |
9282172+dirty | 1237.27 ms | 1242.20 ms | 4.94 ms |
79976dd+dirty | 1223.65 ms | 1224.16 ms | 0.51 ms |
52c0562+dirty | 1219.34 ms | 1221.25 ms | 1.91 ms |
8bda0cc+dirty | 1221.90 ms | 1208.11 ms | -13.79 ms |
34aba08+dirty | 1276.78 ms | 1308.52 ms | 31.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 2.36 MiB | 3.10 MiB | 753.14 KiB |
e99226d+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
3aecc61+dirty | 2.36 MiB | 3.12 MiB | 778.58 KiB |
6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
700cbf4+dirty | 2.36 MiB | 3.08 MiB | 734.22 KiB |
9282172+dirty | 2.36 MiB | 3.11 MiB | 759.89 KiB |
79976dd+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
52c0562+dirty | 2.36 MiB | 3.14 MiB | 793.36 KiB |
8bda0cc+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
34aba08+dirty | 2.36 MiB | 2.85 MiB | 495.32 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 1229.17 ms | 1227.64 ms | -1.54 ms |
e99226d+dirty | 1228.04 ms | 1236.52 ms | 8.48 ms |
3aecc61+dirty | 1240.27 ms | 1240.51 ms | 0.24 ms |
6e8584e+dirty | 1271.71 ms | 1281.26 ms | 9.55 ms |
700cbf4+dirty | 1233.96 ms | 1228.27 ms | -5.69 ms |
9282172+dirty | 1227.60 ms | 1232.69 ms | 5.09 ms |
79976dd+dirty | 1243.73 ms | 1242.40 ms | -1.34 ms |
52c0562+dirty | 1233.94 ms | 1226.29 ms | -7.65 ms |
8bda0cc+dirty | 1217.90 ms | 1223.02 ms | 5.12 ms |
34aba08+dirty | 1268.58 ms | 1276.80 ms | 8.22 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e5bc97b+dirty | 2.92 MiB | 3.66 MiB | 758.40 KiB |
e99226d+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
3aecc61+dirty | 2.92 MiB | 3.69 MiB | 789.88 KiB |
6e8584e+dirty | 2.92 MiB | 3.44 MiB | 536.52 KiB |
700cbf4+dirty | 2.92 MiB | 3.64 MiB | 740.57 KiB |
9282172+dirty | 2.92 MiB | 3.67 MiB | 772.46 KiB |
79976dd+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
52c0562+dirty | 2.92 MiB | 3.69 MiB | 794.15 KiB |
8bda0cc+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
34aba08+dirty | 2.92 MiB | 3.41 MiB | 499.03 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Not sure why, but I keep seeing this Gemfile change after bundle install
I think this has to do with running on Intel 64-bit
architecture.
Also tested with running bundle install
on M1 and did not get any changes.
Ahh, thanks, maybe my pod install is running in Rosetta by accident, I'll check that. |
#skip-changelog
Not sure why, but I keep seeing this Gemfile change after
bundle install