Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): Add swiftlint #4259

Merged
merged 4 commits into from
Nov 11, 2024
Merged

chore(lint): Add swiftlint #4259

merged 4 commits into from
Nov 11, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 11, 2024 •
edited
Loading

📢 Type of change

  • Enhancement

📜 Description

All new iOS tests are in Swift, but we were missing Swift lint in the project.

Rules taken from sentry-cocoa.

💚 How did you test it?

run locally, run in CI

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 426.14 ms 439.67 ms 13.53 ms
Size 17.74 MiB 20.08 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c639edf 466.48 ms 489.57 ms 23.09 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
4cc5c27 460.04 ms 496.32 ms 36.28 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
d2c32bb 448.85 ms 450.19 ms 1.34 ms
2534337 394.15 ms 415.12 ms 20.97 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
cdf2f33 469.46 ms 462.17 ms -7.29 ms

App size

Revision Plain With Sentry Diff
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
4cc5c27 17.73 MiB 19.95 MiB 2.21 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d2c32bb 17.74 MiB 20.08 MiB 2.34 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
cdf2f33 17.74 MiB 20.08 MiB 2.34 MiB

Previous results on branch: kw/lint/add-swift-lint

Startup times

Revision Plain With Sentry Diff
fad4414 420.98 ms 413.30 ms -7.68 ms

App size

Revision Plain With Sentry Diff
fad4414 17.74 MiB 20.08 MiB 2.34 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.57 ms 443.78 ms 40.20 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
2ec71da+dirty 375.64 ms 431.59 ms 55.95 ms
c639edf+dirty 363.39 ms 414.78 ms 51.39 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
2ec71da+dirty 7.15 MiB 8.38 MiB 1.23 MiB
c639edf+dirty 7.15 MiB 8.35 MiB 1.20 MiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Previous results on branch: kw/lint/add-swift-lint

Startup times

Revision Plain With Sentry Diff
fad4414+dirty 366.62 ms 428.12 ms 61.50 ms

App size

Revision Plain With Sentry Diff
fad4414+dirty 7.15 MiB 8.35 MiB 1.20 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.08 ms 1234.27 ms 15.18 ms
Size 2.36 MiB 3.10 MiB 752.64 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0d3e677+dirty 1214.39 ms 1225.70 ms 11.31 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
700cbf4+dirty 1234.59 ms 1227.71 ms -6.88 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
9cab16b+dirty 1237.76 ms 1234.00 ms -3.76 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
148f924+dirty 1214.76 ms 1215.73 ms 0.97 ms
a5d86e1+dirty 1242.47 ms 1239.94 ms -2.53 ms

App size

Revision Plain With Sentry Diff
0d3e677+dirty 2.36 MiB 3.10 MiB 753.12 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
700cbf4+dirty 2.36 MiB 3.08 MiB 734.22 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
9cab16b+dirty 2.36 MiB 3.08 MiB 737.23 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
148f924+dirty 2.36 MiB 3.04 MiB 696.25 KiB
a5d86e1+dirty 2.36 MiB 3.10 MiB 752.65 KiB

Previous results on branch: kw/lint/add-swift-lint

Startup times

Revision Plain With Sentry Diff
fad4414+dirty 1218.31 ms 1225.50 ms 7.19 ms

App size

Revision Plain With Sentry Diff
fad4414+dirty 2.36 MiB 3.10 MiB 752.60 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.85 ms 1222.37 ms -3.48 ms
Size 2.92 MiB 3.66 MiB 757.07 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0d3e677+dirty 1239.02 ms 1241.22 ms 2.20 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
700cbf4+dirty 1233.96 ms 1228.27 ms -5.69 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
9cab16b+dirty 1236.10 ms 1247.16 ms 11.06 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
148f924+dirty 1220.72 ms 1221.30 ms 0.58 ms
a5d86e1+dirty 1230.35 ms 1222.47 ms -7.88 ms

App size

Revision Plain With Sentry Diff
0d3e677+dirty 2.92 MiB 3.66 MiB 758.42 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
700cbf4+dirty 2.92 MiB 3.64 MiB 740.57 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
9cab16b+dirty 2.92 MiB 3.64 MiB 743.06 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
148f924+dirty 2.92 MiB 3.60 MiB 701.88 KiB
a5d86e1+dirty 2.92 MiB 3.66 MiB 757.10 KiB

Previous results on branch: kw/lint/add-swift-lint

Startup times

Revision Plain With Sentry Diff
fad4414+dirty 1233.70 ms 1232.40 ms -1.30 ms

App size

Revision Plain With Sentry Diff
fad4414+dirty 2.92 MiB 3.66 MiB 757.21 KiB

antonis
antonis approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for improving our tooling Krystof 🙇

lucas-zimerman
lucas-zimerman approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@lucas-zimerman lucas-zimerman merged commit 94274ef into main Nov 11, 2024
59 of 62 checks passed
@lucas-zimerman lucas-zimerman deleted the kw/lint/add-swift-lint branch November 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @antonis @lucas-zimerman