Skip to content

Commit

Permalink
fix swift lint
Browse files Browse the repository at this point in the history
  • Loading branch information
@krystofwoldrich
krystofwoldrich committed Nov 11, 2024
1 parent ed17be0 commit 395df45
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryBreadcrumbTests.swift
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import XCTest
import Sentry
import XCTest

class RNSentryBreadcrumbTests: XCTestCase {

Expand Down
28 changes: 14 additions & 14 deletions ...RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayBreadcrumbConverterTests.swift
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import XCTest
import Sentry
import XCTest

final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {

Expand All @@ -12,7 +12,7 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
testBreadcrumb.category = "navigation"
testBreadcrumb.data = [
"from": "HomeScreen",
"to": "ProfileScreen",
"to": "ProfileScreen"
]
let actual = converter.convert(from: testBreadcrumb)

Expand All @@ -36,7 +36,7 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
testBreadcrumb.type = "navigation"
testBreadcrumb.category = "navigation"
testBreadcrumb.data = [
"to": "ProfileScreen",
"to": "ProfileScreen"
]
let actual = converter.convert(from: testBreadcrumb)

Expand All @@ -48,7 +48,7 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
assertRRWebBreadcrumbDefaults(actual: event)
XCTAssertEqual("info", payload["level"] as! String)
XCTAssertEqual("navigation", payload["category"] as! String)
XCTAssertNil(payloadData["from"] ?? nil)
XCTAssertNil(payloadData["from"])
XCTAssertEqual("ProfileScreen", payloadData["to"] as! String)
}

Expand All @@ -63,7 +63,7 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
XCTAssertNotNil(actual)
let event = actual!.serialize()
let data = event["data"] as! [String: Any?]
let payload = data["payload"] as! [String: Any?];
let payload = data["payload"] as! [String: Any?]
assertRRWebBreadcrumbDefaults(actual: event)
XCTAssertEqual(payload["category"] as! String, "app.foreground")
}
Expand All @@ -79,7 +79,7 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
XCTAssertNotNil(actual)
let event = actual!.serialize()
let data = event["data"] as! [String: Any?]
let payload = data["payload"] as! [String: Any?];
let payload = data["payload"] as! [String: Any?]
assertRRWebBreadcrumbDefaults(actual: event)
XCTAssertEqual(payload["category"] as! String, "app.background")
}
Expand Down Expand Up @@ -132,18 +132,18 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {

func testTouchMessageReturnsNilOnEmptyArray() throws {
let actual = RNSentryReplayBreadcrumbConverter.getTouchPathMessage(from: [])
XCTAssertEqual(actual, nil);
XCTAssertEqual(actual, nil)
}

func testTouchMessageReturnsNilOnNilArray() throws {
let actual = RNSentryReplayBreadcrumbConverter.getTouchPathMessage(from: nil as [Any]?)
XCTAssertEqual(actual, nil);
XCTAssertEqual(actual, nil)
}

func testTouchMessageReturnsNilOnMissingNameAndLevel() throws {
let testPath: [Any?] = [["element": "element4", "file": "file4"]]
let actual = RNSentryReplayBreadcrumbConverter.getTouchPathMessage(from: testPath as [Any])
XCTAssertEqual(actual, nil);
XCTAssertEqual(actual, nil)
}

func testTouchMessageReturnsMessageOnValidPathExample1() throws {
Expand All @@ -153,10 +153,10 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
["name": "item2", "label": "label2"],
["name": "item3", "label": "label3", "element": "element3"],
["name": "item4", "label": "label4", "file": "file4"],
["name": "item5", "label": "label5", "element": "element5", "file": "file5"],
["name": "item5", "label": "label5", "element": "element5", "file": "file5"]
]
let actual = RNSentryReplayBreadcrumbConverter.getTouchPathMessage(from: testPath as [Any])
XCTAssertEqual(actual, "label3(element3) > label2 > name1 > label0");
XCTAssertEqual(actual, "label3(element3) > label2 > name1 > label0")
}

func testTouchMessageReturnsMessageOnValidPathExample2() throws {
Expand All @@ -166,17 +166,17 @@ final class RNSentryReplayBreadcrumbConverterTests: XCTestCase {
["name": "item4", "label": "label4", "file": "file4"],
["name": "item5", "label": "label5", "element": "element5", "file": "file5"],
["label": "label6"],
["name": "name7"],
["name": "name7"]
]
let actual = RNSentryReplayBreadcrumbConverter.getTouchPathMessage(from: testPath as [Any])
XCTAssertEqual(actual, "label5(element5, file5) > label4(file4) > label3(element3) > label2");
XCTAssertEqual(actual, "label5(element5, file5) > label4(file4) > label3(element3) > label2")
}

private func assertRRWebBreadcrumbDefaults(actual: [String: Any?]) {
let data = actual["data"] as! [String: Any?]
let payload = data["payload"] as! [String: Any?]
XCTAssertEqual("default", payload["type"] as! String)
XCTAssertEqual((payload["timestamp"] as! Double) * 1000.0, Double(actual["timestamp"] as! Int), accuracy: 1.0)
XCTAssertEqual((payload["timestamp"] as! Double) * 1_000.0, Double(actual["timestamp"] as! Int), accuracy: 1.0)
XCTAssertTrue(payload["timestamp"] as! Double > 0.0)
}

Expand Down
18 changes: 9 additions & 9 deletions packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import XCTest
import Sentry
import XCTest

final class RNSentryReplayOptions: XCTestCase {

Expand All @@ -26,8 +26,8 @@ final class RNSentryReplayOptions: XCTestCase {
] as NSDictionary).mutableCopy() as! NSMutableDictionary
RNSentryReplay.updateOptions(optionsDict)

let experimental = optionsDict["experimental"] as! [String:Any]
let sessionReplay = experimental["sessionReplay"] as! [String:Any]
let experimental = optionsDict["experimental"] as! [String: Any]
let sessionReplay = experimental["sessionReplay"] as! [String: Any]

assertAllDefaultReplayOptionsAreNotNil(replayOptions: sessionReplay)
}
Expand All @@ -41,8 +41,8 @@ final class RNSentryReplayOptions: XCTestCase {
] as NSDictionary).mutableCopy() as! NSMutableDictionary
RNSentryReplay.updateOptions(optionsDict)

let experimental = optionsDict["experimental"] as! [String:Any]
let sessionReplay = experimental["sessionReplay"] as! [String:Any]
let experimental = optionsDict["experimental"] as! [String: Any]
let sessionReplay = experimental["sessionReplay"] as! [String: Any]

assertAllDefaultReplayOptionsAreNotNil(replayOptions: sessionReplay)
}
Expand All @@ -57,8 +57,8 @@ final class RNSentryReplayOptions: XCTestCase {
] as NSDictionary).mutableCopy() as! NSMutableDictionary
RNSentryReplay.updateOptions(optionsDict)

let experimental = optionsDict["experimental"] as! [String:Any]
let sessionReplay = experimental["sessionReplay"] as! [String:Any]
let experimental = optionsDict["experimental"] as! [String: Any]
let sessionReplay = experimental["sessionReplay"] as! [String: Any]

assertAllDefaultReplayOptionsAreNotNil(replayOptions: sessionReplay)
}
Expand Down Expand Up @@ -105,8 +105,8 @@ final class RNSentryReplayOptions: XCTestCase {

XCTAssertEqual(optionsDict.count, 3)

let experimental = optionsDict["experimental"] as! [String:Any]
let sessionReplay = experimental["sessionReplay"] as! [String:Any]
let experimental = optionsDict["experimental"] as! [String: Any]
let sessionReplay = experimental["sessionReplay"] as! [String: Any]

let maskedViewClasses = sessionReplay["maskedViewClasses"] as! [String]
XCTAssertEqual(maskedViewClasses.count, 1)
Expand Down

0 comments on commit 395df45

Please sign in to comment.