-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "feat(tracing): Add propagate_traces
deprecation warning (#3899)"
#4055
Conversation
)" This reverts commit 8a70b76.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4055 +/- ##
==========================================
- Coverage 79.57% 79.53% -0.05%
==========================================
Files 140 140
Lines 15510 15508 -2
Branches 2628 2628
==========================================
- Hits 12342 12334 -8
- Misses 2335 2337 +2
- Partials 833 837 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should revert this change. We want to deprecate propagate_traces
because we intend to remove it in the next major, and want to give our users notice to stop using it. Please see my comment on your issue
Edit: we should only revert adding the deprecation warning to the Celery propagate traces. The other deprecation should stay
@szokeasaurusrex Requires your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamp review
Closes: #4054
We should log deprecation notices but since this notice is not actionable it should be removed.