Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(tracing): Add propagate_traces deprecation warning (#3899)" #4055

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

cmanallen
Copy link
Member

Closes: #4054

We should log deprecation notices but since this notice is not actionable it should be removed.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.53%. Comparing base (7b5904a) to head (6cc1378).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4055      +/-   ##
==========================================
- Coverage   79.57%   79.53%   -0.05%     
==========================================
  Files         140      140              
  Lines       15510    15508       -2     
  Branches     2628     2628              
==========================================
- Hits        12342    12334       -8     
- Misses       2335     2337       +2     
- Partials      833      837       +4     
Files with missing lines Coverage Δ
sentry_sdk/integrations/celery/__init__.py 86.55% <ø> (-0.12%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should revert this change. We want to deprecate propagate_traces because we intend to remove it in the next major, and want to give our users notice to stop using it. Please see my comment on your issue

Edit: we should only revert adding the deprecation warning to the Celery propagate traces. The other deprecation should stay

@cmanallen cmanallen enabled auto-merge (squash) February 14, 2025 14:25
@cmanallen
Copy link
Member Author

@szokeasaurusrex Requires your approval.

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp review

@cmanallen cmanallen merged commit ae68d85 into master Feb 14, 2025
141 checks passed
@cmanallen cmanallen deleted the cmanallen/remove-python-warning branch February 14, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning causing test failures in Sentry
3 participants