chore(profiling): Change continuous profile buffer size #3987
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer size This lowers the sampling frequency of continous profiles to 21Hz and increases the buffer size to 1 minute.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3987 +/- ##
==========================================
+ Coverage 80.16% 80.19% +0.03%
==========================================
Files 139 139
Lines 15403 15403
Branches 2597 2597
==========================================
+ Hits 12348 12353 +5
+ Misses 2211 2206 -5
Partials 844 844
|
sentrivana
approved these changes
Jan 28, 2025
|
Holding off on merging this until I confirm a few things. |
…o/chore/change-continuous-profile-sampling-frequency-and-buffer-size
Zylphrex
changed the title
|
Only bumping the buffer size to 1min and keeping the sampling frequency at 101hz. Reducing the sampling frequency on the SDK will cause pains that are difficult to undo. |
…ling-frequency-and-buffer-size
Zylphrex
deleted the
txiao/chore/change-continuous-profile-sampling-frequency-and-buffer-size
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
lowers the sampling frequency of continuous profiles to 21Hz andincreases the buffer size to 1 minute to match the desired settings for continuous profiling.