Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup scopes types and no-op old scope tracing methods #3985

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jan 21, 2025

closes #3929 and #3969

Copy link

codecov bot commented Jan 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
19146 1 19145 4461
View the top 1 failed tests by shortest run time
pytest internal
Stack Traces | 0s run time
Traceback (most recent call last):
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 1173, in _execute
    return self.con.execute(sql, parameters)    # type: ignore[arg-type]
sqlite3.OperationalError: no such table: file

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 1178, in _execute
    return self.con.execute(sql, parameters)    # type: ignore[arg-type]
sqlite3.OperationalError: no such table: file

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7....../site-packages/_pytest/main.py", line 271, in wrap_session
    session.exitstatus = doit(config, session) or 0
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7....../site-packages/_pytest/main.py", line 325, in _main
    config.hook.pytest_runtestloop(session=session)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7.../site-packages/pluggy/_hooks.py", line 433, in __call__
    return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7.../site-packages/pluggy/_manager.py", line 112, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7.../site-packages/pluggy/_callers.py", line 133, in _multicall
    teardown[0].send(outcome)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7.../site-packages/pytest_cov/plugin.py", line 298, in pytest_runtestloop
    self.cov_controller.finish()
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7....../site-packages/pytest_cov/engine.py", line 44, in ensure_topdir_wrapper
    return meth(self, *args, **kwargs)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7....../site-packages/pytest_cov/engine.py", line 249, in finish
    self.cov.stop()
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7........./site-packages/coverage/control.py", line 757, in save
    data = self.get_data()
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7........./site-packages/coverage/control.py", line 838, in get_data
    self._post_save_work()
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7........./site-packages/coverage/control.py", line 869, in _post_save_work
    self._data.touch_files(paths, plugin_name)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 615, in touch_files
    self._file_id(filename, add=True)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 419, in _file_id
    (filename,)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 1219, in execute_for_rowid
    with self.execute(sql, parameters) as cur:
  File ".../hostedtoolcache/Python/3.7.17.../x64/lib/python3.7/contextlib.py", line 112, in __enter__
    return next(self.gen)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 1207, in execute
    cur = self._execute(sql, parameters)
  File ".../sentry-python/sentry-python/.tox/py3.7-falcon-v1.4/lib/python3.7...................../site-packages/coverage/sqldata.py", line 1195, in _execute
    raise DataError(f"Couldn't use data file {self.filename!r}: {msg}") from exc
coverage.exceptions.DataError: Couldn't use data file '.../sentry-python/sentry-python/.coverage-sentry-py3.7-falcon-v1.4.fv-az1383-82.3653.094722': no such table: file

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sl0thentr0py sl0thentr0py force-pushed the neel/potel/scope-cleanup branch from 094b9a8 to a6c2ee5 Compare January 21, 2025 15:32
@sl0thentr0py sl0thentr0py marked this pull request as ready for review January 21, 2025 15:32
@sl0thentr0py sl0thentr0py changed the title Cleanup scopes wip Cleanup scopes types and no-op old scope tracing methods Jan 21, 2025
@sl0thentr0py sl0thentr0py force-pushed the neel/potel/scope-cleanup branch from a6c2ee5 to 5905d6a Compare January 21, 2025 15:42
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sl0thentr0py sl0thentr0py merged commit 9df9cbf into potel-base Jan 22, 2025
136 of 138 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/scope-cleanup branch January 22, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants