Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Move the Flags group over to the tox gen script #3974

Open
wants to merge 2 commits into
base: ivana/tox-script-4
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 20, 2025

  • remove hardcoded entries for openfeature, launchdarkly, and unleash from the tox template
  • remove them from the ignore list in populate_tox.py
  • run populate_tox.py to fill in entries for them
  • run split_gh_tox_actions.py to generate the CI yaml files so that they correspond to the new tox.ini

Note that this effectively eliminates the -latest tests for the Flags group. The script doesn't generate any -latest tests since it always makes sure to add a pinned entry for the latest version. So in case all of the integrations in a single group are using the script, the whole -latest test category is removed.

@sentrivana sentrivana marked this pull request as ready for review January 20, 2025 15:58
Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but see comment

@@ -754,6 +739,15 @@ deps =
# These come from the populate_tox.py script. Eventually we should move all
# integration tests there.

# ~~~ Flags ~~~
launchdarkly-v9.8.1: launchdarkly-server-sdk==9.8.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the script pull 9.8.0 instead of 9.8.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants