Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Create a separate group for feature flag suites #3911

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jan 9, 2025

Take feature flag tests out of Misc and into their own new Flags group.

Also move Tasks down in the GROUPS dict do that it's alphabetized (except for misc which is at the bottom)

@sentrivana sentrivana changed the title tests: Create a separate group for flag tests tests: Create a separate group for feature flag tests Jan 9, 2025
@sentrivana sentrivana changed the title tests: Create a separate group for feature flag tests tests: Create a separate group for feature flag suites Jan 9, 2025
@sentrivana sentrivana marked this pull request as ready for review January 9, 2025 16:40
@sentrivana sentrivana requested a review from antonpirker January 9, 2025 16:40
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.19%. Comparing base (fa241c3) to head (cb19a0b).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3911      +/-   ##
==========================================
- Coverage   80.20%   80.19%   -0.02%     
==========================================
  Files         140      140              
  Lines       15412    15412              
  Branches     2593     2593              
==========================================
- Hits        12361    12359       -2     
- Misses       2206     2207       +1     
- Partials      845      846       +1     

see 3 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@sentrivana sentrivana enabled auto-merge (squash) January 13, 2025 09:07
@sentrivana sentrivana merged commit 9f9ff34 into master Jan 13, 2025
145 checks passed
@sentrivana sentrivana deleted the ivana/separate-flag-group branch January 13, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants