Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PotelSentrySpanProcessor to SentrySpanProcessor #3828

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

sl0thentr0py
Copy link
Member

  • remove the older one
  • fix propagator inject to not rely on old SentrySpanProcessor span map

* remove the older one
* fix propagator `inject` to not rely on old SentrySpanProcessor span
  map
Copy link

codecov bot commented Nov 28, 2024

❌ 908 Tests Failed:

Tests completed Failed Passed Skipped
18897 908 17989 4424
View the top 3 failed tests by shortest run time
tests.integrations.starlette.test_starlette test_transaction_name_in_traces_sampler[/message/123456-endpoint-http://testserver/message/123456-url]
Stack Traces | 0.005s run time
.../integrations/starlette/test_starlette.py:1076: in test_transaction_name_in_traces_sampler
    client = TestClient(app)
.tox/py3.12-starlette-v0.32/lib/python3.12.../site-packages/starlette/testclient.py:402: in __init__
    super().__init__(
E   TypeError: Client.__init__() got an unexpected keyword argument 'app'
tests.integrations.starlette.test_starlette test_transaction_name_in_traces_sampler[/message/123456-url-http://testserver/message/123456-url]
Stack Traces | 0.005s run time
.../integrations/starlette/test_starlette.py:1076: in test_transaction_name_in_traces_sampler
    client = TestClient(app)
.tox/py3.12-starlette-v0.32/lib/python3.12.../site-packages/starlette/testclient.py:402: in __init__
    super().__init__(
E   TypeError: Client.__init__() got an unexpected keyword argument 'app'
tests.integrations.starlette.test_starlette test_transaction_name_in_middleware[/message/123456-url-http://testserver/message/123456-url]
Stack Traces | 0.006s run time
.../integrations/starlette/test_starlette.py:1126: in test_transaction_name_in_middleware
    client = TestClient(app)
.tox/py3.12-starlette-v0.32/lib/python3.12.../site-packages/starlette/testclient.py:402: in __init__
    super().__init__(
E   TypeError: Client.__init__() got an unexpected keyword argument 'app'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@sl0thentr0py sl0thentr0py merged commit 19d4e07 into potel-base Dec 2, 2024
55 of 125 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/potel/remove-old-processor branch December 2, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants