Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved _serialize_span_attribute into set_attribute #3732

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Moved _serialize_span_attribute into set_attribute #3732

merged 1 commit into from
Nov 5, 2024

Conversation

antonpirker
Copy link
Member

So we never forget to serialize the span attribute.

@antonpirker antonpirker marked this pull request as ready for review November 5, 2024 13:08
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

❌ 1685 Tests Failed:

Tests completed Failed Passed Skipped
20344 1685 18659 4463
View the top 3 failed tests by shortest run time 
tests.integrations.litestar.test_litestar test_middleware_callback_spans
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time 
No failure message available

tests.integrations.litestar.test_litestar test_middleware_partial_receive_send
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

sentrivana
sentrivana approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@antonpirker antonpirker merged commit 453d152 into potel-base Nov 5, 2024
22 of 123 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/move-serialize_span_attributes-into-set_attribute branch November 5, 2024 13:16
@antonpirker antonpirker mentioned this pull request Nov 5, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
Project: POTel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sentrivana