Enable back pressure monitor in Potel #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 3005 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sl0thentr0py
requested changes
Oct 3, 2024
| @@ -45,6 +45,18 @@ def dropped_result(span_context): | |||
| # type: (SpanContext) -> SamplingResult | |||
| trace_state = span_context.trace_state.update(SENTRY_TRACE_STATE_DROPPED, "true") | |||
|
|
|||
| # Tell Sentry why we dropped the transaction/span | |||
There was a problem hiding this comment.
to match the logic in the earlier tracing impl, we should rather do this at the end of the transaction flow, so I'd not do this here but in span processor on_end and only for the root span case. Here it will apply to every span and the numbers will be wrong.
|
If the transaction is not sampled, the |
sl0thentr0py
requested changes
Oct 8, 2024
Co-authored-by: Neel Shah <[email protected]>
sl0thentr0py
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables back pressure management in POtel.
It down samples in case of the transport not being healthy and also sends outcomes to Sentry.
Right now the sampling is done on span level, but should be done on transaction level, which is not possible right now, because we do not have a reference to the transaction (root span) in the sampler right now. This will be done in a separate PR.
The test that is updated in this PR still fails, because it needs the sample_rate to be somewhere on the Span, but this will be done in a separate PR.