Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make explicit sampling work #3739

Closed
sl0thentr0py opened this issue Nov 5, 2024 · 0 comments
Closed

Make explicit sampling work #3739

sl0thentr0py opened this issue Nov 5, 2024 · 0 comments
Assignees
@sentrivana
Milestone
Performance power...

Comments

@sl0thentr0py
Copy link
Member

Passing in an explicit sampled=True/False parameter should override other sampling decisions.
@sl0thentr0py sl0thentr0py self-assigned this Nov 5, 2024
@sentrivana sentrivana mentioned this issue Nov 7, 2024
Merged
sentrivana added a commit that referenced this issue Nov 12, 2024
@sentrivana
Remove custom_sampling_context (#3747)
afd8cc5 
- Add support for the sampled flag for start_span and respect it when making sampling decisions.
- Rework sampling_context in traces_sampler to work with span attributes instead. Make sure we still have the same data accessible as now.

We could go one step further and change the format of sampling_context to just be the actual span attributes without any postprocessing into the current format. I kept the format in line with what we have now to make it easier to update.

See #3746
Closes #3739

This is a breaking change since we're removing custom_sampling_context. It'll break multiple integrations until we fix them (see #3746).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sentrivana sentrivana

Labels
None yet
Projects
None yet
Milestone
Performance powered by OTel (POTel)
Development

No branches or pull requests
2 participants
@sl0thentr0py @sentrivana