Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove push_scope #3403

Closed
szokeasaurusrex opened this issue Aug 7, 2024 · 1 comment · Fixed by #3408
Closed

Remove push_scope #3403

szokeasaurusrex opened this issue Aug 7, 2024 · 1 comment · Fixed by #3408
Assignees
@szokeasaurusrex
Labels
Breaking change needs to go out in a major

Comments

@szokeasaurusrex
Copy link
Member

szokeasaurusrex commented Aug 7, 2024 •
edited
Loading

Remove sentry_sdk.push_scope as well as any tests testing this function.

To be done in potel-base.
@szokeasaurusrex szokeasaurusrex added the Breaking change needs to go out in a major label Aug 7, 2024
@szokeasaurusrex szokeasaurusrex self-assigned this Aug 7, 2024
szokeasaurusrex added a commit that referenced this issue Aug 7, 2024
@szokeasaurusrex
feat(api): Remove sentry_sdk.push_scope
eb9efd5 
Also, remove any tests that test `sentry_sdk.push_scope`.

BREAKING CHANGE: Remove `sentry_sdk.push_scope`.

Closes #3403
@szokeasaurusrex szokeasaurusrex mentioned this issue Aug 7, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Aug 7, 2024
@szokeasaurusrex
feat(api): Remove sentry_sdk.push_scope (#3408)
3936502 
Also, remove any tests that test `sentry_sdk.push_scope`.

BREAKING CHANGE: Remove `sentry_sdk.push_scope`.

Closes #3403
@szokeasaurusrex szokeasaurusrex linked a pull request Aug 7, 2024 that will close this issue
feat(api): Remove sentry_sdk.push_scope #3408
Merged
@szokeasaurusrex
Copy link
Member Author

merged into hotel-base

sentrivana pushed a commit that referenced this issue Aug 12, 2024
@szokeasaurusrex @sentrivana
feat(api): Remove sentry_sdk.push_scope (#3408)
7ac4d71 
Also, remove any tests that test `sentry_sdk.push_scope`.

BREAKING CHANGE: Remove `sentry_sdk.push_scope`.

Closes #3403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
Breaking change needs to go out in a major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): Remove sentry_sdk.push_scope getsentry/sentry-python
1 participant
@szokeasaurusrex