-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ignore_exceptions
& ignore_transactions
#1503
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
721fb6f
feat: Add ignore_exceptions & ignore_transactions
cleptric 18757f5
Fix type annotation
cleptric 693c0b2
Remove unsued parameter
cleptric abfb323
Update src/Client.php
cleptric c834793
Update tests/ClientTest.php
cleptric 88f89d2
Update src/Client.php
cleptric 521d3a1
CS
cleptric 8613949
CS
cleptric 5ce8e81
Merge branch 'master' into ignore-options
cleptric File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,8 @@ | |
* This integration decides whether an event should not be captured according | ||
* to a series of options that must match with its data. | ||
* | ||
* @deprecated since version 3.17, to be removed in 4.0. Use the `ignore_exceptions` option instead | ||
* | ||
* @author Stefano Arlandini <[email protected]> | ||
* | ||
* @psalm-type IntegrationOptions array{ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing is that this works slight different from the now deprecated
IgnoreErrorsIntegration
because that usesis_a
, not sure if intentional but it might be nice to say you want to ignoreHttpException::class
instead of[ClientHttpException::class, ServerHttpException::class, ...]
on the other hand this is more "expected" and you can still make that logic work withbefore_send
of course.Just a little rambling, I have no hard feelings either way so fine with the current impl.