Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support crashpad PAC-stripping on older assemblers. #1125

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

supervacuus
Copy link
Collaborator

fixes: #1123
details: getsentry/crashpad#118

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.68%. Comparing base (57c38d9) to head (5ee0c4c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   82.67%   82.68%   +0.01%     
==========================================
  Files          53       53              
  Lines        7930     7930              
  Branches     1240     1240              
==========================================
+ Hits         6556     6557       +1     
  Misses       1263     1263              
+ Partials      111      110       -1     

Copy link
Member

@JoshuaMoelans JoshuaMoelans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supervacuus supervacuus merged commit 3dc60ed into master Jan 27, 2025
25 checks passed
@supervacuus supervacuus deleted the fix/support_pac_stripping_old_assemblers_crashpad branch January 27, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sentry-native crashpad build fails on Linux arm64: arm64 does not support xpaclri
2 participants