Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: beforeSend dropping events if option is not set #79

Merged
merged 5 commits into from
Apr 24, 2023
Merged

fix: beforeSend dropping events if option is not set #79

merged 5 commits into from
Apr 24, 2023

Conversation

buenaflor
Copy link
Contributor

This PR fixes the issue where if beforeSend is not set during init, it will drop events.

Due to optional chaining the result was always null since the beforeSend callback is by default null.

Additionally: I added more in-depth integration tests for these cases

@buenaflor buenaflor requested a review from marandaneto April 24, 2023 10:22
@buenaflor buenaflor mentioned this pull request Apr 24, 2023
Closed
@buenaflor buenaflor merged commit 10b731b into main Apr 24, 2023
@buenaflor buenaflor deleted the fix/beforesend-if-not-set branch April 24, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buenaflor @marandaneto