Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): check exit value when executing xcodebuild command #326

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

💡 Motivation and Context

Follow up pr of #320

@buenaflor buenaflor requested a review from romtsn as a code owner February 10, 2025 16:35
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.75%. Comparing base (1279a73) to head (7aac04c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...multiplatform/gradle/DerivedDataPathValueSource.kt 53.84% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   80.20%   79.75%   -0.46%     
==========================================
  Files          43       43              
  Lines         793      800       +7     
  Branches      105      106       +1     
==========================================
+ Hits          636      638       +2     
- Misses        103      107       +4     
- Partials       54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor enabled auto-merge (squash) February 10, 2025 16:41
@buenaflor buenaflor merged commit 06ffaf6 into main Feb 10, 2025
9 of 11 checks passed
@buenaflor buenaflor deleted the fix/plugin-derived-data-err-output branch February 10, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants