Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle-plugin): architecture folder name missmatch when using SPM and framework path searching #320

Merged
merged 34 commits into from
Feb 10, 2025

formatting

c0fbf16
Select commit
Loading
Failed to load commit list.
Merged

fix(gradle-plugin): architecture folder name missmatch when using SPM and framework path searching #320

formatting
c0fbf16
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 10, 2025 in 0s

80.20% (+3.19%) compared to d3bf403

View this Pull Request on Codecov

80.20% (+3.19%) compared to d3bf403

Details

Codecov Report

Attention: Patch coverage is 76.72414% with 54 lines in your changes missing coverage. Please review.

Project coverage is 80.20%. Comparing base (d3bf403) to head (c0fbf16).

Files with missing lines Patch % Lines
...tlin/multiplatform/gradle/FrameworkPathResolver.kt 86.72% 8 Missing and 7 partials ⚠️
...sentry/kotlin/multiplatform/gradle/SentryPlugin.kt 25.00% 10 Missing and 5 partials ⚠️
...try/kotlin/multiplatform/gradle/FrameworkLinker.kt 52.38% 6 Missing and 4 partials ⚠️
...orm/gradle/ManualFrameworkPathSearchValueSource.kt 71.42% 5 Missing and 3 partials ⚠️
...otlin/multiplatform/gradle/CocoaFrameworkLinker.kt 89.36% 3 Missing and 2 partials ⚠️
...multiplatform/gradle/DerivedDataPathValueSource.kt 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   77.00%   80.20%   +3.19%     
==========================================
  Files          39       43       +4     
  Lines         635      793     +158     
  Branches       86      105      +19     
==========================================
+ Hits          489      636     +147     
- Misses        100      103       +3     
- Partials       46       54       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov