Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add diagnostics level #287

Merged
merged 8 commits into from
Oct 23, 2024
Merged

feat: add diagnostics level #287

merged 8 commits into from
Oct 23, 2024

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 21, 2024

📜 Description

Add diagnostic level option

💡 Motivation and Context

Closes #286

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

@buenaflor buenaflor requested a review from romtsn as a code owner October 21, 2024 12:21
Copy link
Contributor

github-actions bot commented Oct 21, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9d3c10a

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.00%. Comparing base (abf8a8e) to head (9d3c10a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...platform/extensions/SentryOptionsExtensions.jvm.kt 90.47% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
+ Coverage   76.48%   77.00%   +0.52%     
==========================================
  Files          39       39              
  Lines         608      635      +27     
  Branches       86       86              
==========================================
+ Hits          465      489      +24     
- Misses         97      100       +3     
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor
Copy link
Contributor Author

cc @romtsn

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buenaflor buenaflor merged commit a25dbd0 into main Oct 23, 2024
11 checks passed
@buenaflor buenaflor deleted the feat/add-diagnostics-level branch October 23, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing diagnosticLevel in OptionsConfiguration
2 participants