Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample rate configuration #144

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Nov 9, 2023

📜 Description

💡 Motivation and Context

Closes: #141

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add sample rate configuration ([#144](https://github.com/getsentry/sentry-kotlin-multiplatform/pull/144))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 9e3bae0

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
...platform/extensions/SentryOptionsExtensions.jvm.kt 66.66% <100.00%> (+2.15%) ⬆️
...in/io/sentry/kotlin/multiplatform/SentryOptions.kt 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@buenaflor buenaflor marked this pull request as ready for review November 9, 2023 18:51
@buenaflor buenaflor merged commit 9e7bbfd into main Nov 9, 2023
@buenaflor buenaflor deleted the feat/add-option-sample-trace-ratesD branch November 9, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sample rate option
2 participants