Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make maxUrlLength truncate loop slightly safer/more defensive #918

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

LewisJEllis
Copy link
Contributor

ITT we wish for Array.prototype.forEach.

crumb,
data;

for (var i = 0; i < breadcrumbs.values.length; i++) {
for (var i = 0; i < breadcrumbs.values.length; ++i) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ಠ_ಠ

@LewisJEllis LewisJEllis merged commit 249341b into master Mar 31, 2017
@LewisJEllis LewisJEllis deleted the url-truncate-fix branch March 31, 2017 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants