Fix line/column/url extraction from some eval frames #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
force-pushed
the
fix-eval-frames
branch
from
deba38e to
a67b991
Compare
benvinegar
changed the title
mitsuhiko
approved these changes
Mar 26, 2017
benvinegar
force-pushed
the
fix-eval-frames
branch
from
e1ddc79 to
e8fa25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the behavior in stacktracejs/error-stack-parser (from where I borrowed the tests). The eval "source" line/column is thrown out, and the invocation line (and column, on Chrome) is used instead.
Before we were pulling out URLs that were unusable, so we weren't fetching the source content associated with these eval frames anyways. There is a question of whether Sentry itself should have an "is_eval" meta attribute on frames, or perhaps just a "meta" attribute where we can note in the UI what's going on (cc @mitsuhiko).
cc @LewisJEllis @MaxBittker