-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Add Events to Raven #84
Conversation
First impression, the #1 concern is bloat. I'd like to leverage existing browser events if possible. I don't know too much about real events off the top of my head, but if it requires this much bloat to achieve it in a relatively compatible fashion, I'll just stick with callbacks. One of the goals of Raven is to be as light as possible since we don't want to have to promote deferred loading. |
Bloat is definitely a huge concern. I'm redoing this with DOM Events and we'll take a look at how that works. |
I updated the code to fire native events on the document. |
I also updated the top post with how it works now |
@mattrobenolt - have you had a chance to look over the changes? |
@bisrael, I have not. I'm currently at PyCon, so I'll have to take a closer look after this weekend. |
This looks good to me. Sorry it took so long. :) |
Hello, I know the PR is closed and all, but I have stumbled upon libraries that use those messages and have not found much documentation about it... |
Fix rare recursion condition in patchGlobal
Please do not accept this pull request yet
This adds several events:
Right now, I'm triggering three events:
ravenHandle
: triggers as Raven gets called from TraceKit to handle an errorstackInfo
,options
ravenSuccess
: triggers when Raven has successfully reported an error to sentrydata
,src
ravenFailure
: triggers when Raven tried to report an error, but got back an bad response code.data
,src
Discussion Points:
Relevant Issues: #81 and #83
Edit: Updated to match current commits