Can enable synthetic traces globally via stacktrace: true (fixes #743) #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxBittker
reviewed
Nov 12, 2016
| var data = objectMerge({ | ||
| message: msg + '' // Make sure it's actually a string | ||
| }, options); | ||
|
|
||
| if (options && options.stacktrace) { | ||
| if (this._globalOptions.stacktrace || (options && options.stacktrace)) { |
There was a problem hiding this comment.
still need (options && here, now that options is checked above?
|
Nice, when will it be available in a tagged version? |
|
@romainneutron Looks like it's in 3.9 now! |
|
Sorry for the delay on this – many Sentry developers (myself included) were out on holidays over the past few weeks, and I generally err on making sure we're all available when pushing releases. |
|
@benvinegar thank you! Can you also update documentation for this? |
denstepa
pushed a commit
to denstepa/raven-js
that referenced
this pull request
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @MaxBittker