Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume previous shouldSendCallback exists in RN plugin (fixes #692) #694

Merged
merged 2 commits into from
Aug 18, 2016

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Aug 18, 2016

@benvinegar
Copy link
Contributor Author

This change will mean that if FATAL_ERROR_KEY is not in data, transmission will only take place if originalCallback exists and returns true (i.e. user-defined callback). Otherwise this will return undefined and transmission will not take place.

I'm not 100% sure if this is the intended behavior or not. Need someone more familiar to chime off on this (@nevir).

@benvinegar
Copy link
Contributor Author

Re-reading the code, I understand now that this code branch is reached if we're dealing with a non-fatal, in which case we should return true (process the exception) unless an original shouldSend handler is present, in which case we use the return value from that.

@nevir
Copy link
Contributor

nevir commented Aug 18, 2016

Re-reading the code, I understand now that this code branch is reached if we're dealing with a non-fatal, in which case we should return true (process the exception) unless an original shouldSend handler is present, in which case we use the return value from that.

Yup! This looks correct

@benvinegar benvinegar merged commit bef9fa7 into master Aug 18, 2016
@benvinegar
Copy link
Contributor Author

wfm! 3.5.1 going out soon

@benvinegar benvinegar deleted the fix-rn-plugin branch August 18, 2016 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants