Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Fix express import in gcpfunction #5097

Merged
merged 1 commit into from
May 13, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 12, 2022

This fixes a spot where we're importing types only to say that we're importing types only, in order to get rid of a warning in build. (If we don't say so, it gets mad because we only have @types/express, not express, as a listed dependency.)

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.75 KB (-6.91% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.19 KB (-9.95% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.49 KB (-7.25% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.43 KB (-9.56% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.33 KB (-16.84% 🔽)
@sentry/browser - Webpack (minified) 61.44 KB (-24.82% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.35 KB (-16.88% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.81 KB (-10.92% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.41 KB (-6.39% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.96 KB (-6.24% 🔽)

@lobsterkatie lobsterkatie merged commit cac6312 into 7.x May 13, 2022
@lobsterkatie lobsterkatie deleted the kmclb-fix-express-import-in-gcpfunction branch May 13, 2022 13:36
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 13, 2022
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
This fixes a spot where we're importing types only to _say_ that we're importing types only, in order to get rid of a warning in build. (If we don't say so, it gets mad because we only have `@types/express`, not `express`, as a listed dependency.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants