Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(serverless): Do not throw on flush error #5090

Merged
merged 3 commits into from
May 13, 2022

Conversation

lforst
Copy link
Member

@lforst lforst commented May 12, 2022

There is a number of issues on the fact that we fail or stall serverless functions when anything goes wrong while flushing:

Considering our fire & forget mantra for events, this PR changes the behaviour of our lambda/cloud function wrappers to catch and log errors that occur while flushing. Up until now we threw upwards if something went wrong while flushing.

Todo after merging: Remove https://docs.sentry.io/platforms/node/guides/aws-lambda/#ignore-sentry-errors section

Ref: https://getsentry.atlassian.net/browse/WEB-918

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 18.75 KB (-6.91% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 58.19 KB (-9.95% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 17.49 KB (-7.26% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 52.43 KB (-9.56% 🔽)
@sentry/browser - Webpack (gzipped + minified) 19.33 KB (-16.84% 🔽)
@sentry/browser - Webpack (minified) 61.44 KB (-24.82% 🔽)
@sentry/react - Webpack (gzipped + minified) 19.35 KB (-16.88% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 42.81 KB (-10.92% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 24.41 KB (-6.4% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 22.95 KB (-6.25% 🔽)

@lforst lforst force-pushed the lforst-catch-serverless-flush-errors branch from 1a728a6 to 28fb0a2 Compare May 12, 2022 12:02
@lforst lforst force-pushed the lforst-catch-serverless-flush-errors branch from 69a5eae to 7caf12b Compare May 12, 2022 12:45
@lforst lforst marked this pull request as ready for review May 12, 2022 12:59
@lforst lforst requested review from AbhiPrasad and Lms24 May 12, 2022 14:00
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants