ref(serverless): Do not throw on flush error #5090
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a number of issues on the fact that we fail or stall serverless functions when anything goes wrong while flushing:
Considering our fire & forget mantra for events, this PR changes the behaviour of our lambda/cloud function wrappers to catch and log errors that occur while flushing. Up until now we threw upwards if something went wrong while flushing.
Todo after merging: Remove https://docs.sentry.io/platforms/node/guides/aws-lambda/#ignore-sentry-errors section
Ref: https://getsentry.atlassian.net/browse/WEB-918