ref(utils): Add logic to enable skipping of normalization #5052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
size-limit report 📦
|
AbhiPrasad
reviewed
May 9, 2022
packages/utils/src/normalize.ts
Outdated
| // We're also done if we've reached the max depth | ||
| if (depth === 0) { | ||
| // At this point we know `serialized` is a string of the form `"[object XXXX]"`. Clean it up so it's just `"[XXXX]"`. | ||
| return stringified.replace('object ', ''); |
There was a problem hiding this comment.
Why did we move this below the memoize?
There was a problem hiding this comment.
I thought there was a case where we need to move the memoize call to avoid circular references with objects for which we skip normalization. Your comment made me think about it again and
a) I think there is actually no such case
b) if there were such a case, moving it is pointless because skipping normalization is already "dangerous" in that regard.
Anyways, moved it back, thanks ^^ -> 77e3096
lforst
force-pushed
the
lforst-normalization-skip-flag
branch
from
fb17f47 to
77e3096
Compare
AbhiPrasad
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements logic that allows us to skip normalization of objects by marking them with a
__sentry_skip_normalization__property.We will use this in an upcoming PR to fix behaviour in the
ExtraErrorDataintegration: #5053Ref: https://getsentry.atlassian.net/browse/WEB-600