Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v7] feat: Drop support for Node 6 #4851

Merged
merged 4 commits into from
Apr 7, 2022
Merged

[v7] feat: Drop support for Node 6 #4851

merged 4 commits into from
Apr 7, 2022

Conversation

AbhiPrasad
Copy link
Member

Drops support for Node 6. Remove from our CI pipeline and fix a test.

Resolves https://getsentry.atlassian.net/browse/WEB-779

@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 4, 2022
@AbhiPrasad
Copy link
Member Author

This allows us to bump a bunch of our deps, like go onto Jest 25! #4231

@AbhiPrasad
Copy link
Member Author

Ah I guess this needs Test (Node 6) to be dropped as a required check

@lforst
Copy link
Member

lforst commented Apr 5, 2022

Should we also bump all the engines fields in the package.jsons to 8? PR looks good otherwise.

@AbhiPrasad
Copy link
Member Author

Should we also bump all the engines fields in the package.jsons to 8? PR looks good otherwise.

Yes we should, will do!

@AbhiPrasad AbhiPrasad changed the base branch from master to 7.x April 7, 2022 01:18
@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 7, 2022 01:18
@AbhiPrasad AbhiPrasad merged commit 7e5c074 into 7.x Apr 7, 2022
@AbhiPrasad AbhiPrasad deleted the v7-abhi-drop-node-6 branch April 7, 2022 01:19
@AbhiPrasad AbhiPrasad changed the title [v7] Drop support for Node 6 [v7] feat: Drop support for Node 6 Apr 7, 2022
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @Lms24
[v7] feat: Drop support for Node 6 (#4851)
25aa095
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @Lms24
[v7] feat: Drop support for Node 6 (#4851)
20c7773
lobsterkatie pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad @lobsterkatie
[v7] feat: Drop support for Node 6 (#4851)
7ea63c7
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @Lms24
[v7] feat: Drop support for Node 6 (#4851)
e45e397
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad @lobsterkatie
ref: Drop support for Node 6 (#4851)
ebff719
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref: Drop support for Node 6 (#4851)
fb72c0f
@Lms24 Lms24 mentioned this pull request Jun 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lforst