-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken logDebug() in IE9 and below #473
Conversation
A wild @gabalafou appears. |
Have you tested this w/ the console plugin (plugins/console.js)? The purpose here was to use the original prototype method – not just the console object – in case |
Funny-- that file notes the same behavior about IE9:
Alternatively, you just don't try to log anything when the original throws? i.e.,--
|
I just copied what console.js does |
It affects both Not sure if you submitted your comment before my most recent update (looks like they may have crossed each other). |
We can't use I'd probably try and find a way to remove the bind call from console.js too. I imagine this was added mistakenly, but at least you have to opt-in to using plugins. |
@gabalafou – if you change it to bail out if it cannot call the original prototype method, e.g. try { /* log thingy */ } catch (err) { /* skip debug logging IE<10 */ } I'll accept and merge. Thanks for your help btw. |
IE8 may not have |
Brilliant. Let me just verify this and we're golden. |
Fix broken logDebug() in IE9 and below
Hmm, in hindsight, I really should've asked you to squash these first. Oh well. |
Should we also change this in the console plugin? |
@mattrobenolt – Yeah. |
No description provided.