Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed gecko regExp for parding more complicated stack lines #252

Merged
merged 1 commit into from
Nov 3, 2014

Conversation

Poplava
Copy link
Contributor

@Poplava Poplava commented Aug 29, 2014

Issue #249

I got stack like this in Firefox:

.events["click [data-test]"]@http://example.com/user/views/UserView.js:23:17
jQuery.event.dispatch@http://example.com/vendor/jquery/jquery.js:4641:1
jQuery.event.add/elemData.handle@http://example.com/vendor/jquery/jquery.js:4309:1

But in Sentry I got only 2 lines:

jQuery.event.dispatch@http://example.com/vendor/jquery/jquery.js:4641:1
jQuery.event.add/elemData.handle@http://example.com/vendor/jquery/jquery.js:4309:1

This pull request fixes this issue.

@mattrobenolt
Copy link
Contributor

Seems reasonable. Would really like some tests for these cases though.

@Poplava
Copy link
Contributor Author

Poplava commented Aug 29, 2014

Sure. I'll write tests. I found all possible types of FF stack traces. It will be easy. mb I'll do on this weekend.

@mattrobenolt
Copy link
Contributor

We also put together this, fwiw: https://github.com/defunctzombie/browser-stacks

@mattrobenolt
Copy link
Contributor

What's the worst that can happen?

mattrobenolt added a commit that referenced this pull request Nov 3, 2014
fixed gecko regExp for parding more complicated stack lines
@mattrobenolt mattrobenolt merged commit 25efd3a into getsentry:master Nov 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants