Make Tracekit report correctly angularJS errors

[vperron]

Hi,

I'm pretty sure there are some issues in the way this commit is done (no version bump, etc), sorry in advance.
I noticed the stack frames corresponding to something like:

ReferenceError: xxx is not defined
    at new <anonymous> (http://127.0.0.1:3333/js/app.js:12354:19)
    at invoke (http://127.0.0.1:3333/js/vendor.js:29215:17)
    at Object.instantiate (http://127.0.0.1:3333/js/vendor.js:29226:23)
    at http://127.0.0.1:3333/js/vendor.js:32625:28

were silently skipped in Tracekit, because of the two words "new" and "" next to each other in the first frame.

This patch enhances (and in the end, simplifies) the regular expression that was used to decode the stack frames in Chrome. It was checking for 0-1 occurrences of [object], then some non-space chars, then 0-1 occurrences of [as xxx], but included everything in the same capture group.
I just capture what's before the first opening parenthesis.

Other methods (gecko-based detection) seem fine. Test has been added.

[mattrobenolt]

Can you back out the changes made to the dist/ folder please?

[vperron]

Sure. I read that part of the contributing/ docs a little quick, sorry.

EDIT: and didn't get the notification for your lightning-speed answer.

[mattrobenolt]

Thanks. :) Lemme review this later and I'll get back with you. At first glance, this seems reasonable though.

[robinwassen]

I would advice against using this patch this way, the reason is that it is a local patch on the included TraceKit file instead of into the TraceKit project.

Send this patch to TraceKit instead and update the TraceKit version used by raven-js when the pull request has been merged.

[mattrobenolt]

@robinwassen TraceKit is unmaintained, so it's purely vendorized into our project. We already have a ton of modifications to it.

[mattrobenolt]

@vperron Thanks. :) 🍰

[robinwassen]

@mattrobenolt Fair enough! Then it makes more sense :)