fix(sveltekit): Avoid loading vite config to determine source maps setting #15440
+135
−144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we determine the user-provided source map generation settings in our
sentrySvelteKit
vite plugins.Previously, we'd call Vite's
loadConfigFromFile
function which sounded good but had a couple of drawbacks:vite
in a vite config creates a circular import chain (fixed via fix(sveltekit): Avoid top-levelvite
import #15371)sentrySvelteKit
loads Vite config in the wrong mode #15414, we always loaded themode: "production"
version of the config, which was also problematic.Since there's no reliably way to read the
mode
for Vite, and parsingprocess.argv
also seemed sketchy, I decided to go down the Vite-recommended route and to read the config in theconfig
hook. This required a change in our@sentry/vite-plugin
which was released in 3.2.0, so this PR also bumps the Vite plugin version.Concrete changes:
config
hook of our source maps settings sub pluginfilesToDeleteAfterUpload
promise whenever we know what to set it to (using a promise allows us to defer this decision to plugin hook runtime rather than plugin creation time)closes #15414