fix(sveltekit): Avoid request body double read errors #15368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix an unreproducible bug reported in #14583: It seems like our SDK calling
cloneon therequestobject passed to SvelteKit request handlers causes double read errors when the request body is consumed in user code.While I'm not sure about this, my best guess is that it has something to do with SvelteKit creating a new request object from the actual incoming request in a special way.
This PR removes the
clone()call (tests would fail if it was still called) from our request handler. This is safe because our SDK does not consume the request body. Cloning here was a precautionary measure that apparently backfired.If it turns out that this doesn't fix the problem, we should revert this PR.