feat(core): Allow adding measurements without global client #13612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Sep 9, 2024
| @@ -8,8 +8,7 @@ import { getActiveSpan, getRootSpan } from '../utils/spanUtils'; | |||
| /** | |||
| * Adds a measurement to the current active transaction. | |||
There was a problem hiding this comment.
let's update the docstring to reflect this.
AbhiPrasad
approved these changes
Sep 9, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on updating
sentry-javascript-bundler-pluginsto use v8 of the JavaScript SDK, I found that I was unable to set measurements as the global client is not used.If you're not using a global client, there is currently no way to add measurements because
Sentry.setMeasurement()relies ongetActiveSpan()which in turn relies ongetCurrentScope().This PR moves the
activeSpaninto the last parameter which defaults togetActiveSpan().