Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): Always add BrowserTracing #13244

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 6, 2024

The bundler-plugins still refer to the option as excludePerformanceMonitoring (here), but this is going to be renamed to excludeTracing, so I already used the new naming as discussed with @Lms24 and @mydea.

closes #13013

@s1gr1d s1gr1d requested review from Lms24, mydea and lforst and removed request for Lms24 August 6, 2024 07:52
@mydea
Copy link
Member

mydea commented Aug 6, 2024

let's split this into two PRs, as the topics are related but not the same!

@s1gr1d
Copy link
Member Author

s1gr1d commented Aug 6, 2024

Edited this PR and added another PR for the build option: #13250

@s1gr1d s1gr1d force-pushed the sig/browsertracing-astro branch from bcdc3a6 to 915894a Compare August 6, 2024 10:19
@s1gr1d s1gr1d changed the title feat(astro): Always add BrowserTracing; Add build option to disable feat(astro): Always add BrowserTracing Aug 6, 2024
@s1gr1d s1gr1d merged commit fdb20a0 into develop Aug 6, 2024
96 checks passed
@s1gr1d s1gr1d deleted the sig/browsertracing-astro branch August 6, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always add browserTracingIntegration in Astro SDK
3 participants