fix(feedback): Improve feedback border color in dark-mode, and prevent auto-dark mode when a theme is picked #12126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
ryan953
changed the title
…t auto-dark mode when a theme is picked
ryan953
force-pushed
the
ryan953/fix-feedback-border-color
branch
from
ceeb439 to
1930ff8
Compare
mydea
approved these changes
May 21, 2024
Jesse-Box
previously requested changes
May 21, 2024
| @@ -27,7 +27,7 @@ const DEFAULT_DARK: InternalTheme = { | |||
| accentBackground: PURPLE, | |||
| successColor: '#2da98c', | |||
| errorColor: '#f55459', | |||
| border: '1.5px solid rgba(41, 35, 47, 0.5)', | |||
| border: '1.5px solid rgba(180, 180, 180, 0.25)', | |||
ryan953
commented
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the developer sets
theme: 'dark'ortheme: 'light'in their sentry config, then we should prevent the browser from applying auto-dark mode to the widget. That mode guesses at the correct color to use, and sometimes gets it wrongAlso, I've picked a better color for the border in dark mode.
There are a few states to test:
prefers-color-schememedia query)which refer to these 2 settings inside the chrome devtools:
Note:images show a slightly different border than what's implemented.
References: