feat: Add trpcMiddleware back to serverside SDKs
#11374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(not in this PR, but we should prob. add an E2E test for this...) |
Bundle ReportChanges will increase total bundle size by 4.76kB ⬆️
|
@mydea Absolutely. I wanna do it in this PR actually. That's why it's still in draft. |
mydea
reviewed
Apr 2, 2024
| }, | ||
| }, | ||
| span => { | ||
| let maybePromiseResult; |
There was a problem hiding this comment.
l: can we rewrite this to use handleCallbackErrors?
There was a problem hiding this comment.
It will very much not reduce the code here by much, if at all, because we need to inspect maybePromiseResult.
size-limit report 📦
|
lforst
added a commit
that referenced
this pull request
Apr 3, 2024
The `trpcMiddleware` export will move from `Handlers` to a top level export in v8. This is more or less backporting #11374 to v7.
mydea
approved these changes
Apr 4, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back the
trpcMiddlewarewe accidentally removed when removing the old@sentry/nodepackage.