Changes to use karma and adds firefox headless #1087
Conversation
|
@kamilogorek Not sure why SAUCE variables are missing, pls halp? :) |
|
@deiga Travis doesn't expose ENV vars to PRs coming from external contributors (non-org accounts), as they could be easily extracted and used on other projects. We're working on getting around this soon. I'll review your PR today, thanks! :) |
There was a problem hiding this comment.
I tried to run those changes locally, and I'm not able to trigger any tests.
npm run test:unit
give me this output
START:
11 10 2017 15:07:13.565:WARN [watcher]: Pattern "/Users/kamilogorek/Projects/sentry/raven-js/build/raven.test.js" does not match any file.
11 10 2017 15:07:13.619:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9876/
11 10 2017 15:07:13.620:INFO [launcher]: Launching browsers ChromeHeadless, FirefoxHeadless with unlimited concurrency
11 10 2017 15:07:13.626:INFO [launcher]: Starting browser ChromeHeadless
11 10 2017 15:07:13.634:INFO [launcher]: Starting browser Firefox
11 10 2017 15:07:14.262:INFO [HeadlessChrome 0.0.0 (Mac OS X 10.12.6)]: Connected on socket iEPdymhObeJm1HLDAAAA with id 33628822
11 10 2017 15:07:16.206:INFO [Firefox 56.0.0 (Mac OS X 10.12.0)]: Connected on socket NL4Ypu659I4dCYZ2AAAB with id 33702021
Finished in 0.018 secs / 0 secs @ 15:07:16 GMT+0200 (CEST)
SUMMARY:
✔ 0 tests completed
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:karma:unit: `karma start karma.config.js "--single-run"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test:karma:unit script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/kamilogorek/.npm/_logs/2017-10-11T13_07_16_620Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test:unit: `npm run test:karma:unit -- --single-run`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test:unit script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/kamilogorek/.npm/_logs/2017-10-11T13_07_16_669Z-debug.log
karma.config.js
Outdated
| } | ||
| } | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Those two config files are in 90% the same. Can we move common config to something like karma-base.config.js and then import it in karma-integration.config.js and karma-unit.config.js?
| var runner = mocha.run(); | ||
| var failedTests = []; | ||
|
|
||
| var flattenTitles = function (test) { |
There was a problem hiding this comment.
This code is required in order for tests to work on SauceLabs.
|
@kamilogorek Could you use https://docs.travis-ci.com/user/encryption-keys/ to add the SAUCE env variables? You need to run I'll work on those comments tonight |
|
@kamilogorek I addressed the issues with the index and saucelabs by changing to use karma for that too. |
Not really, it will still fail. Per docs:
I got bitten by my own setup... 🤦♂️ Thanks! Will reverify it Today :) |
|
Oh, yeah. That's a bummer. Does SauceLabs have any kind of ACL, where you could have "public" credentials which only travis could use to send data? |
|
Not that I know of. We'll most likely write a bot that'd run those tests for us instead. |
|
@deiga can you grant me write access your fork? I rebased your changes and added some changes that would like to include here, as I don't want to open a new PR :) https://github.com/deiga/raven-js/settings/collaboration |
|
@kamilogorek done |
kamilogorek
force-pushed
the
switch-to-karma-and-integrate-headless-firefox
branch
from
2e294cf to
d8c8cae
Compare
|
@deiga merged :) You can take a look at my latests commits to see what had to be changed in order to run everything on SauceLabs
|
Addressses #1045