-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lifecycleHook in vue plugin #1053
Conversation
Vue.js v2.2.0 also captures errors in component lifecycle hooks https://vuejs.org/v2/api/#errorHandler
Whoops, look like one of test failed. |
Hey @ankurk91, thanks for contributing, appreciate it. In order to fix the test, you need to call Three things should be changed:
|
Now one of the task is failing that is not related to this PR
|
It's my silly config mistake, tests are passing just fine :) |
Pre-commit hook was causing indentation issues, it should be fixed now. |
Had to rebase it locally and pass through prettier for code formatting. Thanks! |
Vue.js v2.2.0 also captures errors in component lifecycle hooks
https://vuejs.org/v2/api/#errorHandler
Before submitting a pull request, please verify the following: