Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Deprecate Replay, ReplayCanvas, Feedback classes #10270

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 19, 2024

Instead, users should use the new functional styles.

Note that we'll probably actually un-deprecate Replay in some form in v8, as we'll be keeping the class around there for sure (as there is a lot of logic in there...). But users should not use it, so deprecating this now!

While at it, I also deprecated the old InitSentryForEmber method in favor of init().

It's slightly unfortunate that I missed this, but we probably shouldn't have exposed ReplayCanvas as a class anymore at all 😬 maybe we wait before we document this etc. until we merged the functional style. cc @billyvg

@mydea mydea self-assigned this Jan 19, 2024
Copy link
Contributor

github-actions bot commented Jan 19, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.69 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.95 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.84 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.58 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.96 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.18 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.19 KB (0%)
@sentry/browser - Webpack (gzipped) 22.53 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.36 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.83 KB (+0.08% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.35 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.04 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.04 KB (+0.11% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 72.87 KB (+0.14% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 35.92 KB (+0.08% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.35 KB (0%)
@sentry/react - Webpack (gzipped) 22.58 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.97 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.25 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@billyvg
Copy link
Member

billyvg commented Jan 19, 2024

We should remember to update the usage of our class components inside of https://github.com/getsentry/getsentry after this is released (feedback + replay)

Instead, users should use the new functional styles.

Note that we'll probably actually un-deprecate `Replay` in some form in v8, as we'll be keeping the class around there for sure (as there is a lot of logic in there...). But users should not use it, so deprecating this now!
@mydea mydea force-pushed the fn/replay-functional branch from 5505ffd to 95fc8a3 Compare January 23, 2024 13:35
@mydea mydea merged commit a682534 into develop Jan 23, 2024
86 checks passed
@mydea mydea deleted the fn/replay-functional branch January 23, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants