Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8] Merge @sentry/utils into @sentry/core #9832

Closed
2 of 4 tasks
Tracked by #9508
mydea opened this issue Dec 14, 2023 · 2 comments
Closed
2 of 4 tasks
Tracked by #9508

[v8] Merge @sentry/utils into @sentry/core #9832

mydea opened this issue Dec 14, 2023 · 2 comments
Milestone
8.0.0

Comments

@mydea
Copy link
Member

mydea commented Dec 14, 2023 •
edited by AbhiPrasad
Loading

In v8, let's merge utils into core, so all shared, runtime agonstic things are in utils, while runtime specific things should be moved out of utils into either browser or server-runtimes packages.

If we have things that are e.g. browser specific that are needed by e.g. replay or feedback packages, we need to see what we do with them. But either we create a new e.g. browser-utils package for this (if needed) or, if it's not a lot, we just duplicate stuff a bit - we'll need to see case-by-case if this is necessary.

Tasks
Preview Give feedback
  1. feat: Add @sentry-internal/browser-utils #11381
    AbhiPrasad
  2. ref(browser): Move utils to @sentry-internal/browser-utils #11451
    AbhiPrasad
@mydea mydea added this to the 8.0.0 milestone Dec 14, 2023
@mydea mydea mentioned this issue Dec 14, 2023
Closed
@AleshaOleg AleshaOleg mentioned this issue Jan 17, 2024
Merged
2 tasks
@AbhiPrasad AbhiPrasad mentioned this issue Mar 15, 2024
Merged
AbhiPrasad added a commit that referenced this issue Mar 18, 2024
@AbhiPrasad
feat(v8/utils): Remove deprecated util functions (#11143)
9a62445 
ref #9832

Deletes deprecated imports from utils package in preparation to move it
to core/related.

Also important because deleting `addOrUpdateIntegration` and it's
associated tests means that we remove more usages of class based
integrations.
@s1gr1d s1gr1d self-assigned this Mar 19, 2024
@AbhiPrasad AbhiPrasad mentioned this issue Apr 2, 2024
Merged
AbhiPrasad added a commit that referenced this issue Apr 5, 2024
@AbhiPrasad
feat: Add @sentry-internal/browser-utils (#11381)
3f9cd43 
This PR creates a `browser-utils` package that contains browser specific
utils that can be shared between the browser, replay, and feedback
packages.

Eventually we will move `browserTracingIntegration` outside of this
package, but the instrumentation handlers will remain here. We will also
move the browser related utils in `@sentry/utils` to this package.

Given this removes `@sentry-internal/tracing` entirely, it is a part of
#9885

ref #9832
@AbhiPrasad AbhiPrasad mentioned this issue Apr 5, 2024
Merged
AbhiPrasad added a commit that referenced this issue Apr 8, 2024
@AbhiPrasad
ref(browser): Move utils to @sentry-internal/browser-utils (#11451)
8aca02d 
ref #9832

Building off #11381,
this moves browser related utils into the browser utils package.

Next step is to move `browserTracingIntegration` into browser!
@AbhiPrasad
Copy link
Member

Given we have moved all browser related code into the browser utils package, this can be considered done.

We can now review on a more case-by-case basis if we should move functions from utils

cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat(v8/utils): Remove deprecated util functions (getsentry#11143)
c9ca85a 
ref getsentry#9832

Deletes deprecated imports from utils package in preparation to move it
to core/related.

Also important because deleting `addOrUpdateIntegration` and it's
associated tests means that we remove more usages of class based
integrations.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
feat: Add @sentry-internal/browser-utils (getsentry#11381)
6bfd4ed 
This PR creates a `browser-utils` package that contains browser specific
utils that can be shared between the browser, replay, and feedback
packages.

Eventually we will move `browserTracingIntegration` outside of this
package, but the instrumentation handlers will remain here. We will also
move the browser related utils in `@sentry/utils` to this package.

Given this removes `@sentry-internal/tracing` entirely, it is a part of
getsentry#9885

ref getsentry#9832
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this issue Apr 19, 2024
@AbhiPrasad @cadesalaberry
ref(browser): Move utils to @sentry-internal/browser-utils (getsentry…
4e4ba16 
…#11451)

ref getsentry#9832

Building off getsentry#11381,
this moves browser related utils into the browser utils package.

Next step is to move `browserTracingIntegration` into browser!
@mydea
Copy link
Member Author

mydea commented Apr 22, 2024

we did part of this, the rest we may do in v9 (or not...)

@mydea mydea closed this as completed Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@mydea @AbhiPrasad @s1gr1d