Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose isSetup on Raven object #305

Closed
rich-glow opened this issue Dec 22, 2014 · 6 comments · Fixed by #309
Closed

expose isSetup on Raven object #305

rich-glow opened this issue Dec 22, 2014 · 6 comments · Fixed by #309

Comments

@rich-glow
Copy link

I would like to be able to call Raven.isSetup(), but currently isSetup is a private function.

Is there a reason this is not already possible? If not I will make a PR for it.

@joeyespo
Copy link
Contributor

👍

@mattrobenolt
Copy link
Contributor

This seems reasonable.

Though, I'm mostly curious about the use-case for this. In what scenario do you need/want to check this status?

mattrobenolt added a commit that referenced this issue Dec 29, 2014
@joeyespo
Copy link
Contributor

For me it was to allow running locally without needing to set the SENTRY_DSN environment variable.

I worked around it with

var sentry = null;
if (Ember.ENV.SENTRY_DSN) {
  sentry = Raven.config(Ember.ENV.SENTRY_DSN).install();
}

and then check and use the sentry variable rather than the Raven global for manually capturing exceptions and messages. Although perhaps this is the better way to do it.

@vkovalskiy
Copy link

Should not Raven suppress Raven has not been configured error message when we actually checking it's configuration status by isSetup method?

@lowik
Copy link

lowik commented Jul 10, 2015

+1

@marcelboettcher
Copy link

@vkovalskiy +1 that does not make any sense to me, too

matghaleb pushed a commit to matghaleb/raven-js that referenced this issue Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants