Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9] Stop using prepack script in Deno SDK and rely on build/X path instead #14311

Closed
AbhiPrasad opened this issue Nov 14, 2024 · 2 comments · Fixed by #14829
Closed

[v9] Stop using prepack script in Deno SDK and rely on build/X path instead #14311

AbhiPrasad opened this issue Nov 14, 2024 · 2 comments · Fixed by #14829
Assignees
@andreiborza
Labels
Package: deno Issues related to the Sentry Deno SDK

Comments

@AbhiPrasad
Copy link
Member

Description

sentry-javascript/packages/deno/scripts/prepack.js

Line 9 in 5b77377

* TODO(v9): Remove this script and change the Deno SDK to import from build/X.

@AbhiPrasad AbhiPrasad added the Package: deno Issues related to the Sentry Deno SDK label Nov 14, 2024
@lforst
Copy link
Member

lforst commented Nov 15, 2024

@AbhiPrasad I struggled to understand how this is breaking which is why wouldn't have put it into v9. Can you explain?

@AbhiPrasad
Copy link
Member Author

See #12698 as some context about why removing the prepack script was breaking.

@andreiborza andreiborza self-assigned this Dec 23, 2024
@andreiborza andreiborza mentioned this issue Dec 23, 2024
Merged
andreiborza added a commit that referenced this issue Dec 23, 2024
@andreiborza
feat(deno)!: Remove deno prepack (#14829)
16647a5 
Closes: #14311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreiborza andreiborza

Labels
Package: deno Issues related to the Sentry Deno SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(deno)!: Remove deno prepack getsentry/sentry-javascript
3 participants
@lforst @AbhiPrasad @andreiborza