Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky CI]: replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts #13321

Closed
mydea opened this issue Aug 12, 2024 · 0 comments · Fixed by #13338
Closed

[Flaky CI]: replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts #13321

mydea opened this issue Aug 12, 2024 · 0 comments · Fixed by #13338
Assignees

Comments

@mydea
Copy link
Member

mydea commented Aug 12, 2024

Flakiness Type

Timeout

Name of Job

Playwright bundle_tracing_replay_tracing_min Tests

Name of Test

replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts:107:11 › captures response size without Content-Length header

Link to Test Run

https://github.com/getsentry/sentry-javascript/actions/runs/10351287096/job/28649710474

Details

 [chromium] › replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts:107:11 › captures response size without Content-Length header 

    Test timeout of 30000ms exceeded.

    Error: page.waitForRequest: Test timeout of 30000ms exceeded.

       at ../utils/helpers.ts:203

      201 |
      202 | export function waitForErrorRequest(page: Page): Promise<Request> {
    > 203 |   return page.waitForRequest(req => {
          |               ^
      204 |     const postData = req.postData();
      205 |     if (!postData) {
      206 |       return false;

        at waitForErrorRequest (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/utils/helpers.ts:203:15)
        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts:133:45

    Error: page.waitForResponse: Test timeout of 30000ms exceeded.

       at ../utils/replayHelpers.ts:120

      118 |
      119 |   // eslint-disable-next-line @typescript-eslint/no-floating-promises
    > 120 |   const promise = page.waitForResponse(res => {
          |                        ^
      121 |     const req = res.request();
      122 |
      123 |     const event = getReplayEventFromRequest(req);

        at collectReplayRequests (/home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/utils/replayHelpers.ts:120:24)
        at /home/runner/work/sentry-javascript/sentry-javascript/dev-packages/browser-integration-tests/suites/replay/extendNetworkBreadcrumbs/xhr/captureResponseSize/test.ts:134:53
@mydea mydea self-assigned this Aug 12, 2024
mydea added a commit that referenced this issue Aug 14, 2024
…13338)

This streamlines some stuff in our browser integration tests, to fix
some flakiness (hopefully).

The biggest change is that instead of always building into `dist` for
each test file, each test will now build into a random subfolder, e.g.
`dist/abc`. This way, multiple tests in a single file will never
conflict with each other.

Additionally it also streamlines some of the tests I encountered while
looking at stuff, hopefully reducing flakes further.

Closes #13321
Zen-cronic pushed a commit to Zen-cronic/sentry-javascript that referenced this issue Aug 26, 2024
…etsentry#13338)

This streamlines some stuff in our browser integration tests, to fix
some flakiness (hopefully).

The biggest change is that instead of always building into `dist` for
each test file, each test will now build into a random subfolder, e.g.
`dist/abc`. This way, multiple tests in a single file will never
conflict with each other.

Additionally it also streamlines some of the tests I encountered while
looking at stuff, hopefully reducing flakes further.

Closes getsentry#13321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant