fix(vue): Re-throw error when no errorHandler exists

getsentry · Jan 9, 2025 · a6459e2 · a6459e2
1 parent 785aab3
commit a6459e2
Show file tree

Hide file tree

Showing 4 changed files with 126 additions and 143 deletions.
diff --git a/dev-packages/e2e-tests/test-applications/vue-3/tests/errors.test.ts b/dev-packages/e2e-tests/test-applications/vue-3/tests/errors.test.ts
@@ -19,7 +19,7 @@ test('sends an error', async ({ page }) => {
           type: 'Error',
           value: 'This is a Vue test error',
           mechanism: {
-            type: 'generic',
+            type: 'vue-errorHandler',
             handled: false,
           },
         },
@@ -47,7 +47,7 @@ test('sends an error with a parameterized transaction name', async ({ page }) =>
           type: 'Error',
           value: 'This is a Vue test error',
           mechanism: {
-            type: 'generic',
+            type: 'vue-errorHandler',
             handled: false,
           },
         },

diff --git a/packages/vue/src/errorhandler.ts b/packages/vue/src/errorhandler.ts
@@ -30,16 +30,22 @@ export const attachErrorHandler = (app: Vue, options: VueOptions): void => {
     setTimeout(() => {
       captureException(error, {
         captureContext: { contexts: { vue: metadata } },
-        mechanism: { handled: false },
+        mechanism: { handled: !!originalErrorHandler, type: 'vue-errorHandler' },
       });
     });
 
     // Check if the current `app.config.errorHandler` is explicitly set by the user before calling it.
     if (typeof originalErrorHandler === 'function' && app.config.errorHandler) {
       (originalErrorHandler as UnknownFunc).call(app, error, vm, lifecycleHook);
-    }
-
-    if (options.logErrors) {
+    } // TODO(v9): Always throw when no user-defined error handler is provided (this will log the error to the console as well). Delete the Code with logErrors below
+    /* else {
+      throw error;
+    } */
+
+    if (!originalErrorHandler) {
+      throw error;
+      // eslint-disable-next-line deprecation/deprecation
+    } else if (options.logErrors) {
       const hasConsole = typeof console !== 'undefined';
       const message = `Error in ${lifecycleHook}: "${error && error.toString()}"`;
 

diff --git a/packages/vue/src/types.ts b/packages/vue/src/types.ts
@@ -44,6 +44,8 @@ export interface VueOptions {
   /**
    * When set to `true`, original Vue's `logError` will be called as well.
    * https://github.com/vuejs/vue/blob/c2b1cfe9ccd08835f2d99f6ce60f67b4de55187f/src/core/util/error.js#L38-L48
+   *
+   * @deprecated Will be removed in future versions of the SDK. The error will always be logged unless you define a custom Vue errorHandler.
    */
   logErrors: boolean;