Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mechanism type to suppressed for suppressed exceptions #4125

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Jan 29, 2025

📜 Description

Set mechanism type to suppressed for suppressed exceptions so customers can distinguish exceptions causes from suppressed exceptions.

Screenshot 2025-01-29 at 11 07 06

💡 Motivation and Context

Closes #4059

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9092e40

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 437.31 ms 472.43 ms 35.12 ms
Size 1.65 MiB 2.31 MiB 678.23 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: feat/suppressed_exceptions_mechanism_type

Startup times

Revision Plain With Sentry Diff
c33ea04 514.25 ms 545.59 ms 31.34 ms
34aecd9 379.29 ms 464.42 ms 85.13 ms

App size

Revision Plain With Sentry Diff
c33ea04 1.65 MiB 2.31 MiB 678.22 KiB
34aecd9 1.65 MiB 2.31 MiB 678.22 KiB

@adinauer adinauer merged commit 2fc1ed7 into main Jan 29, 2025
37 checks passed
@adinauer adinauer deleted the feat/suppressed_exceptions_mechanism_type branch January 29, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark suppressed exceptions in Sentry UI
3 participants